On Dec 10, 2013, at 5:44 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Wed, Dec 11, 2013 at 10:42:02AM +0900, Simon Horman wrote:
>> On Tue, Dec 10, 2013 at 05:40:00PM -0800, Ben Pfaff wrote:
>>> On Wed, Dec 11, 2013 at 10:34:14AM +0900, Simon Horman wrote:
>>>> On Tue, Dec 10, 2013 at 05:07:14PM -0800, Ben Pfaff wrote:
>>>>> On Wed, Dec 11, 2013 at 10:01:12AM +0900, Simon Horman wrote:
>>>>>> Remove count_1bits_8() from util.c.
>>>>>> It appears to be unused since
>>>>>> c3cc4d2dd2658238 ("util: Better count_1bits().")
>>>>>>
>>>>>> Cc: Jarno Rajahalme <jrajaha...@nicira.com>
>>>>>> Signed-off-by: Simon Horman <ho...@verge.net.au>
>>>>>
>>>>> It's used from inline functions defined in util.h.
>>>>
>>>> Ok, I guess not under all circumstances as this seemed to work for me.
>>>>
>>>> I'll look into this more closely but I was seeing
>>>> a warning about it being undeclared from sparse.
>>>
>>> I posted a fix for that warning, and Jarno already reviewed it, but I
>>> hadn't pushed it because I'm working hard on a high-priority issue.
>>> I'll do that in a minute since it's causing you trouble too.
>>
>> Thanks, sorry for the noise, I can easily imagine higher-priority issues.
>
> Warnings are really annoying, especially since I normally compile with
> -Werror, so of course it's fine to propose fixes. Thank you.
I just realized that I failed to exclude the definition of count_1bits_8 for
64-bit builds. It is only used with 32-bit code now. I’ll propose a patch in a
moment.
Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
