On Thu, Dec 5, 2013 at 9:26 AM, Ben Pfaff <b...@nicira.com> wrote: > On Thu, Dec 05, 2013 at 05:24:51PM +0000, James Page wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > On 05/12/13 17:07, Ben Pfaff wrote: > > > On Thu, Dec 05, 2013 at 04:16:39PM +0000, James Page wrote: > > >> Later versions of gcc on some architectures push atomic > > >> functions out into a separate atomic library; add a check to see > > >> when this is required and add it to LIBS if need be. > > >> > > >> Signed-off-by: James Page <james.p...@ubuntu.com> > > > > > > May I assume that you have tested this and it fixes the problem > > > with the GCC versions and architectures that have the problems? > > > Can you give an example of a GCC version and architecture that has > > > the problem? > > > > I had a specific problem with GCC 4.8.2 on powerpc architecture for > > Ubuntu 14.04: > > > > > https://launchpadlibrarian.net/155235096/buildlog_ubuntu-trusty-powerpc.openvswitch_2.0.0-0ubuntu1_FAILEDTOBUILD.txt.gz > > > > this was fixed by adding -latomic for the test-atomic link; however > > when I backported this package back to 12.04 (gcc 4.6.3) it fails to > > find libatomic and breaks. > > > > I reworked the fix into this patch today. > > OK, great. Will you add that to the commit log? Thanks. >
Never mind, I updated the commit log myself. -- "I don't normally do acked-by's. I think it's my way of avoiding getting blamed when it all blows up." Andrew Morton
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
