On Tue, Nov 26, 2013 at 11:24:48AM -0800, Jarno Rajahalme wrote:
> Add the missing code for generating IPv6 packets for testing purposes.
> 
> Also make flow_compose() set the l4 and l7 pointers more consistently
> with flow_extract().
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>

Thanks, this should be less surprising behavior.

packet_set_ipv6_tc() and packet_set_ipv6_flow_label() might be
overkill since most of their code exists to update the IPv6 checksum,
which isn't right anyway at the point where we call them here.

I think that most of the ETH_TYPE_IPV6 case is a duplicate of the
ETH_TYPE_IPV4 case.  Can we factor out any code into a helper?

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to