On Tue, Nov 26, 2013 at 09:04:41AM -0800, Jarno Rajahalme wrote:
> Allow TCP flags match specification with symbolic flag names.  TCP
> flags are optionally specified as a string of flag names, each
> preceded by '+' when the flag must be one, or '-' when the flag must
> be zero.  Any flags not explicitly included are wildcarded.  The
> existing hex syntax is still allowed, and is used in flow dumps when
> all the flags are matched.
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
> ---
> v2: Addressed Ben's comments.

Thanks.

I think that the manpage can still be slightly improved.  How about
this:

Alternatively, the flags can be specified by their symbolic names
(listed below), each preceded by either \fB+\fR (plus sign) for a flag
that must be set, or \fB\-\fR for a flag that must be unset, without
any other delimiters between the flags.  Flags not mentioned are
wildcarded.  For example, \fBtcp,tcp_flags=+syn\-ack\fR matches TCP
SYNs that are not ACKs.

Acked-by: Ben Pfaff <b...@nicira.com>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to