On Thu, Nov 21, 2013 at 2:20 PM, Thomas Graf <tg...@suug.ch> wrote:
> On 11/21/13 at 06:23pm, Ben Hutchings wrote:
>> On Thu, 2013-11-21 at 19:13 +0100, Thomas Graf wrote:
>> > +
>> > +/**
>> > + * V2:
>>
>> This is not kernel-doc format so don't use '/**'.
>
> I was hoping kernel-doc would pick it up but it doesn't.
> I'll convert it.
>
>> > + if (info->genlhdr->version < OVS_DP_VER_FEATURES) {
>> > + WARN_ONCE(dp->user_features, "Dropping previously "
>> > + "announced user features");
>>
>> Log messages shouldn't be split like this as it makes them harder to
>> find. There should also be a newline at the end of the message.
>
> Right, I'll fix this up. We seem to have many of these unfixed.
>
> Jesse, do you want a full respin or just a v2 of this patch?
Whichever is easier is fine.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
