On Fri, Nov 08, 2013 at 10:54:36AM -0800, Jarno Rajahalme wrote: > Use one callback instead of many, helps in adding new > functionality later on. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
It seems OK, barely, to combine these two functions into one callback. Will the new functionality added later on mash even more functionality into the same callback? If so, then that seems like a need better filled by a "class" structure with multiple function pointers, than by one increasingly screwball interface. The 'output' and 'userspace' parameters were sort of self-explanatory, at least, but this new 'callback' seriously needs some explanation in comments. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
