Ben,
Looks mostly good (and a helpful improvement on the prior documentation). One
small error:
+ and the rate at which it is willing to transmit them. Open vSwitch
uses a detection multiplier of three, meaning that an endpoint
+ signals a connectivity fault if it fails to receive BFD consecutive
+ control messages at the expected rate.
I think that should be "...three consecutive BFD control messages…"
Same error occurs again in
<column name="bfd" key="forwarding_if_rx" type='{"type": "boolean"}'>
+ True to consider the interface capable of packet I/O as long as it
+ continues to receive any packets (not just BFD packets). This
+ prevents link congestion that causes BFD consecutive control packets
+ to be lost from marking the interface down.
Same fix: should be "...three consecutive BFD control messages…"
And 3 typos:
In <column name="bfd" key="check_tnl_key" type='{"type": "boolean"}'>
+ Set to true to make BFD accept only control messages with an tunnel
"an" -> "a"
In <column name="bfd" key="bfd_dst_mac">
+ to set the MAC used as destination for transmitted BFD packet and
"packet" -> "packets"
In <column name="bfd_status" key="remote_diagnostic">
+ In case of a problem, set to a short message that reports what the
+ remote endpoint's BFD session thinks is wrong
Looks like a missing period.
Would you like to update my vtep.xml patch with these improvements?
Bruce
On Oct 24, 2013, at 9:57 AM, Ben Pfaff wrote:
> On Thu, Oct 24, 2013 at 09:53:19AM -0700, Ben Pfaff wrote:
>> On Thu, Oct 24, 2013 at 08:30:51AM -0700, Bruce Davie wrote:
>>> A number of new key-value pairs have been added to the bfd and bfd_status
>>> columns of the OVS schema since the VTEP schema was created. To aid
>>> interoperability between OVS instances and VTEPs, this patch brings
>>> the VTEP schema into line with that of OVS.
>>>
>>> Signed-off-by: Bruce Davie <bda...@vmware.com>
>>
>> I sent out a patch a few minutes ago to update the BFD documentation,
>> which much of this patch is based upon. My patch is at:
>> http://openvswitch.org/pipermail/dev/2013-October/033238.html
>
> It may be easier to read with spaces-only changes omitted:
> http://openvswitch.org/pipermail/dev/2013-October/033240.html
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
