On Thu, Oct 10, 2013 at 03:00:09PM -0700, Romain Lenglet wrote: > On Oct 10, 2013, at 2:56 PM, Romain Lenglet <rleng...@vmware.com> wrote: > > > On Oct 7, 2013, at 2:33 PM, Ben Pfaff <b...@nicira.com> wrote: > > > >> This prevents using an older datapath from breaking forwarding. > >> > >> CC: Romain Lenglet <rleng...@vmware.com> > >> Signed-off-by: Ben Pfaff <b...@nicira.com>
> > The *_sample() functions are called only by upcalls triggered by > > the NXAST_SAMPLE actions. If the datapath doesn't support that > > action, there's none, so this function is never called, so there's > > no need to do this check here. Oops. Thanks for pointing that out, I'll fix it. > > Instead, I'd add this check into compose_ipfix_action() in > > ofproto/ofproto-dpif-xlate.c, to call compose_sample_action() to > > add NXAST_SAMPLE actions only if supported. OK. > It would even be simpler to just disable IPFIX altogether with a > warning log if that action is not supported by the datapath. OVS 1.11 supported IPFIX without NXAST_SAMPLE on the older datapaths, right? Eliminating that support would be a regression, I think, so since it isn't hard to retain it I think it would be better to do so. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
