Changes will be made to allow "ovs-appctl time/warp" wake up all threads. With that, all threads will try calling "coverage_run()". And it will be impossible to deterministically check the output of the "ovs-appctl coverage/show" command. Thusly, this commit removes the unit test for the coverage/show command.
Signed-off-by: Alex Wang <al...@nicira.com> --- tests/ofproto-dpif.at | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index b706373..87e3d0e 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -2841,40 +2841,6 @@ AT_CHECK([ovs-appctl bond/show | sed -n '/^.*may_enable:.*/p'], [0], [dnl OVS_VSWITCHD_STOP AT_CLEANUP - -# Unit test for appctl coverage/show command -AT_SETUP([ofproto-dpif - coverage/show]) -OVS_VSWITCHD_START - -ovs-appctl time/stop -# before the first 5 seconds, nothing can be calculated but the total count. -# there should be two unixctl commands received, but the count of the "appctl -# coverage/show" command is not updated to the total. so there show only 1. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.0/sec 0.000/sec 0.0000/sec total: 1 -]) - -ovs-appctl time/warp 5000 -# at first 5 second time instant, should have stats. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.6/sec 0.050/sec 0.0008/sec total: 3 -]) - -for i in `seq 0 10`; do ovs-appctl time/warp 5000; done -# advance to first 1 minute time instant. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.2/sec 0.250/sec 0.0042/sec total: 15 -]) - -ovs-appctl time/warp 60000 -# advance to next 1 minute time instant directly, should observe the per-minute -# rate drop. -AT_CHECK([ovs-appctl coverage/show | sed -n '/^unixctl_received.*/p'], [], [dnl -unixctl_received 0.4/sec 0.033/sec 0.0047/sec total: 17 -]) - -OVS_VSWITCHD_STOP -AT_CLEANUP AT_BANNER([ofproto-dpif - flow translation resource limits]) -- 1.7.9.5 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
