On Sun, Oct 06, 2013 at 10:11:11PM -0700, Neil Mckee wrote: > Please comment on this proposed patch. It adds the standard > sFlow-TUNNEL structures to the sFlow export, which will be helpful > for tracing tunneled traffic through a network fabric in real-time. > > As part of doing that, it switches over from using odp_port to ofp_port > as the port reference used in dpif-sflow, which allows some only-for-sflow > code to be removed elsewhere. It also completely removes the private > port-lookup hash table that dpif-sflow was maintaining and replaces > it with a simple callback to the parent dpif - presenting the parent with > a structure to fill in with just the necessary details about the port. > This makes it easier for the parent dpif to control what port state is > exposed to the sFlow module during the processing of a packet-sample. > > (This same mechanism can now be extended to expose some > bundle/LAG information, so the standard sFlow-LAG structures can > be exported too, but that can be in another patch). > > This patch also cleans up the way sFlow is treated in ofproto-xlate.c, so > that the upcall cookie just contains the essential details and the > sFlow-specific encoding is migrated into ofproto-dpif-sflow.c. > > Finally a new test for sFlow tunnel structures was added that exercises > the new code. So 'make check TESTSUITEFLAGS="-k sflow"' now runs > two separate tests. > > One very specific question is asked in an XXX comment in ofproto-dpif.c, > regarding which lock should be acquired during the new callback. A little > guidance there would be most appreciated.
This commit increases the size of the sflow userdata (the 'sflow' member in struct user_action_cookie) from 8 bytes to 12. If the size increase can be avoided, then it is desirable to avoid it, because only recent versions of the Open vSwitch kernel module support userdata longer than 8 bytes. I'd like to see a full discussion of Jesse's comments. I see various other minor issues but nothing that will be much trouble. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
