On Sep 20, 2013, at 1:04 AM, pritesh <pritesh.koth...@cisco.com> wrote:
> Here, datapath support for setting nsh service index (nsi) is added.
> nsi can now be set on outgoing packet depending on port settings or
> set_nsi action.
>
> Signed-off-by: pritesh <pritesh.koth...@cisco.com>
>
...
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 4f47a48..4335d67 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -46,6 +46,8 @@
>
> #include "vlan.h"
>
> +#define NSH_M_NSI 0x000000FF
> +
Is this the same as NSH_M_NSI currently defined in nsh.h?
> static struct kmem_cache *flow_cache;
>
>
...
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 6239400..de9e9e4 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -305,6 +305,7 @@ enum ovs_tunnel_key_attr {
> OVS_TUNNEL_KEY_ATTR_DONT_FRAGMENT, /* No argument, set DF. */
> OVS_TUNNEL_KEY_ATTR_CSUM, /* No argument. CSUM packet. */
> OVS_TUNNEL_KEY_ATTR_NSP, /* be32 NSH service path */
> + OVS_TUNNEL_KEY_ATTR_NSI, /* u8 NSH service index */
Document here if NSI value zero is allowed and/or how it behaves.
Current code seems to transmit zero values as 1, which seems weird.
> __OVS_TUNNEL_KEY_ATTR_MAX
> };
>
> --
> 1.7.9.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
