On Mon, Sep 30, 2013 at 2:27 PM, Jesse Gross <je...@nicira.com> wrote: > Some very quick high level things while I look at this: > > On Mon, Sep 30, 2013 at 1:01 PM, Pravin B Shelar <pshe...@nicira.com> wrote: >> Following patch breaks down ovs_mutex into multiple locks. This >> patch specifically targets flow-install. By breaking down >> ovs-locking parallel flow-installs are possible. >> >> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> > > I think we should have some additional documentation on the new > locking scheme, both in the commit message and in the source code. > There's an existing comment in datapath.c that I believe is now > inaccurate. > > I got a sparse warning with this patch: > CHECK /home/jgross/openvswitch/datapath/linux/flow_table.c > /home/jgross/openvswitch/datapath/linux/flow_table.c:364:12: warning: > context imbalance in 'tbl_insert' - wrong count at exit > > It looks like a real issue to me if we hit the EEXIST error path.
I will send out locking changes in separate patch series. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
