On Tue, Oct 1, 2013 at 10:38 AM, Alex Wang <al...@nicira.com> wrote:
>
> I don't really like the function name monitor_handler(). It's not
>> really handling anything in the same sense that the miss_handler is.
>> I think we should rename the function interface_monitor(), and
>> set_subprogram_name("interface_monitor") as well.
>>
>> It's probably cleaner to take the monitor_rwlock once and hold it over
>> monitor_run() and monitor_wait().
>>
>
>
> Sure, I can modify the code.
>
I still feel it is not very clear to name it interface_monitor while the
module is called ofproto_dpif_monitor. Can I use monitor_main()? and just
set the name to "monitor". The set_subprogram_name cannot exceeds 16 char's
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
