On Wed, Sep 25, 2013 at 12:55:43AM -0700, Gurucharan Shetty wrote:
> With this commit, whenever the verbosity is enabled with '-m'
> option, the ovs-dpctl dump-flows command will display the flows with
> in_port field showing the name instead of a port number.
> 
> Conversely, one can also use a name in the in_port field with del-flow,
> add-flow and mod-flow commands of ovs-dpctl. One should also be able
> to use the port name when supplying the datapath flow as an input
> to ofproto/trace command.
> 
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>

Does ofproto_unixctl_trace() leak its port_names simap?

Would you mind refining this comment to something like "A map from odp
port number to name." so that it's clear what the main direction of the
mapping is?
> +/* A map between odp port number and its name. */
> +struct odp_portno_names {

Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to