Thanks! On Sep 25, 2013 5:38 PM, "Simon Horman" <[email protected]> wrote:
> On Wed, Sep 25, 2013 at 09:03:17AM -0700, Ben Pfaff wrote: > > On Wed, Sep 25, 2013 at 08:57:08AM -0700, Ben Pfaff wrote: > > > On Wed, Sep 25, 2013 at 01:31:08PM +0900, Simon Horman wrote: > > > > The sole purpose of this change is to avoid sparse warnings > > > > about memset of zero length in the case where the zero field > > > > of struct flow is zero bytes long, as is the case after > > > > "Remove mpls_depth field from flow". > > > > > > > > Signed-off-by: Simon Horman <[email protected]> > > > > > > > > --- > > > > > > > > This patch could trivially be: applied as-is; trivially up-dated > > > > so that it can be applied before "Remove mpls_depth field from flow." > > > > which would also need to be trivially updated; or dropped entirely. > > > > I am equally comfortable with any of those options. > > > > > > Previously when we've needed no padding we've just deleted the 'zeros' > > > member entirely. I think that's what I'd prefer this time too. > > > > Oh and I'd prefer to see that done as part of patch 1. > > Sure, no problem. >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
