On Tue, Sep 24, 2013 at 02:18:34PM -0700, Ben Pfaff wrote:
> On Mon, Sep 23, 2013 at 02:36:40PM -0700, Justin Pettit wrote:
> > Both OpenFlow and OVSDB have new IANA-assigned port numbers.  We still
> > default to the original values (6633 and 6632, respectively), but this
> > commit logs a warning.  In the future, we will switch to the official
> > values (6653 and 6640, respectively).
> > 
> > Signed-off-by: Justin Pettit <jpet...@nicira.com>
> > ---
> >  NEWS         |    3 +++
> >  lib/stream.c |   10 ++++++++++
> >  2 files changed, 13 insertions(+), 0 deletions(-)
> > 
> > diff --git a/NEWS b/NEWS
> > index eae1146..5fb3703 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -1,5 +1,8 @@
> >  Post-v2.0.0
> >  ---------------------
> > +    - Log a warning message that the default OpenFlow (6633->6653) and
> > +      OVSDB (6632->6640) TCP port numbers will change to their
> > +      IANA-assigned numbers in a future release.
> 
> This NEWS item reads oddly to me.  How about this:
> 
>     - The default OpenFlow and OVSDB ports will change to
>       IANA-assigned numbers in a future release.  Consider updating
>       your installations to specify port numbers instead of using the
>       defaults.
> 
> Acked-by: Ben Pfaff <b...@nicira.com>

Also, make sure that you run the unit tests before you push this.  The
WARN messages could potentially cause tests to fail (because they
check the logs for unexpected WARN and ERR messages).
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to