On Tue, Sep 17, 2013 at 11:56:57AM -0700, Ben Pfaff wrote:
> On Tue, Sep 17, 2013 at 10:22:04AM -0700, Jarno Rajahalme wrote:
> > I get test failures after this patch, seems to relate to slow path
> > processing. Haven't looked at them, but I see failures on 656 and 657
> > come and go, so those are most likely unrelated test timing issues.
> 
> Thanks for the report, I'll check it out.

This incremental patch fixes the problem.  I'll resend the series.

diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index e13a5f8..00d74b4 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -381,11 +381,11 @@ udpif_dispatcher(void *arg)
 static void *
 udpif_miss_handler(void *arg)
 {
-    struct list misses = LIST_INITIALIZER(&misses);
     struct handler *handler = arg;
 
     set_subprogram_name("miss_handler");
     for (;;) {
+        struct list misses = LIST_INITIALIZER(&misses);
         size_t i;
 
         ovs_mutex_lock(&handler->mutex);
-- 
1.7.10.4

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to