On Thu, Sep 12, 2013 at 10:01:14AM -0700, Alex Wang wrote:
> This commit fixes a place in bridge.c where smap_destroy() is not
> always called after smap_init().  Though there is no memory leak
> now, it is necessary to fix it and prevent memory leak in the
> future when smap_init() is modified to allocate dynamic memory.
> 
> Reported-by: Ansis Atteka <aatt...@nicira.com>
> Signed-off-by: Alex Wang <al...@nicira.com>

It looks good to me, but: when you revise a patch within a series,
please do it one of two ways:

        * Post the new version of the patch as a reply to the previous
          version.

        * Repost the whole series.

The reason is that, when there's a v2 of one patch, but no v2 of other
patches, then it gets really confusing for reviewers.  But when you do
either of the above, it's obvious.

So would you mind reposting this 2-patch series?

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to