This looks good to me.
On Wed, Sep 11, 2013 at 10:28 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Tue, Sep 10, 2013 at 01:33:08PM -0700, Andy Zhou wrote:
> > OFPTC11_TABLE_MISS_MASK is not a valid configuration, but to indicate
> > there are only 2 bits being used for table miss configuration. Move
> > it out of the enum definition.
> >
> > Reported-by: Simon Horman <ho...@verge.net.au>
> > Signed-off-by: Andy Zhou <az...@nicira.com>
>
> I agree that OFPTC11_TABLE_MISS_MASK isn't really an enum value so it
> would be better separately. But on the other hand it's harder to find
> it when it's not right with the other values. So how about this (this
> is a manually edited diff, I'm sure it won't apply):
>
> > @@ -452,7 +454,6 @@ enum ofp11_table_config {
> > pipeline (OpenFlow 1.0
> > behavior). */
> > OFPTC11_TABLE_MISS_DROP = 2 << 0, /* Drop the packet. */
> > - OFPTC11_TABLE_MISS_MASK = 3
> > +#define OFPTC11_TABLE_MISS_MASK 3
> > };
> >
> > /* Flow setup and teardown (controller -> datapath). */
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
