On Wed, Sep 04, 2013 at 12:20:26PM -0700, Ethan Jackson wrote:
> > I'm pretty sure that the above will self-deadlock on
> > ofproto->facets.rwlock, because facet_remove() write-locks it.
> >
> > My understanding is that the locking on this classifier is superfluous
> > anyway since only a single thread accesses it--it's only there to
> > suppress Clang lock warnings--so I just moved the unlock just past the
> > cls_cursor_init().
> 
> Oops, good catch.  Thanks

I found a bunch of stuff while testing and sent out a 6-patch series
with this one at the front.  It would be good to get all of them
reviewed.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to