On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar <pshe...@nicira.com> wrote: > diff --git a/datapath/linux/compat/include/net/checksum.h > b/datapath/linux/compat/include/net/checksum.h > index 502d02d..2bead4b 100644 > --- a/datapath/linux/compat/include/net/checksum.h > +++ b/datapath/linux/compat/include/net/checksum.h > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,7,0) > +#define inet_proto_csum_replace16 rpl_inet_proto_csum_replace16 > +void inet_proto_csum_replace16(__sum16 *sum, struct sk_buff *skb, > + const __be32 *from, const __be32 *to, > + int pseudohdr); > +#endif
Is there any need to have the rpl_ macro? Doesn't this simply not exist before 3.7? > diff --git a/datapath/vlan.h b/datapath/vlan.h > index aee5551..1356aed 100644 > --- a/datapath/vlan.h > +++ b/datapath/vlan.h > @@ -93,11 +93,6 @@ static inline int vlan_deaccel_tag(struct sk_buff *skb) > if (unlikely(!skb)) > return -ENOMEM; > > - if (get_ip_summed(skb) == OVS_CSUM_COMPLETE) > - skb->csum = csum_add(skb->csum, > - csum_partial(skb->data + (2 * ETH_ALEN), > - VLAN_HLEN, 0)); > - Don't we still need to add the value to skb->csum? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
