On Thu, Aug 29, 2013 at 09:54:40PM -0700, Ben Pfaff wrote: > On Fri, Aug 30, 2013 at 01:48:15PM +0900, Simon Horman wrote: > > On Thu, Aug 29, 2013 at 02:00:51PM -0700, Ben Pfaff wrote: > > > From: Neil Zhu <z...@centecnetworks.com> > > > > > > This doesn't include a dpif implementation of groups functionality. In > > > its > > > current form, it is untested. Before this is committed, it needs some > > > more comments and an ovs-ofctl manpage update. > > > > > > Signed-off-by: Neil Zhu <z...@centecnetworks.com> > > > Co-authored-by: Ben Pfaff <b...@nicira.com> > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > ... > > > > @@ -1710,6 +1721,9 @@ ofpact_to_openflow10(const struct ofpact *a, struct > > > ofpbuf *out) > > > /* XXX */ > > > break; > > > > > > + case OFPACT_GROUP: > > > + break; > > > + > > > > Is the idea here to silently skip over OFPACT_GROUP > > when encoding to OpenFlow10? > > That's the idea for now. It's not ideal. Perhaps we can do something > better later (for example, we could add an extension action, I suppose).
Thanks for the clarification. I agree that its not ideal but a reasonable solution for now. > > > > + Indirect group : > > > + max_groups = 0x3 actions=0x00000007 > > > + Fast Failover group : > > > > There is a trailing space on the line above. > > Thanks, fixed. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
