Thanks Ben, I like this version. By calling coverage_run() in time_poll() , it can provide more accurate stats.
On Thu, Aug 29, 2013 at 9:15 PM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Aug 27, 2013 at 09:25:10PM -0700, Alex Wang wrote: > > This commit changes the "ovs-appctl coverage/show" command to show the > > per-second, per-minute and per-hour rates of function invocation. More > > importantly, this makes using coverage counter an easy way to monitor > > the execution of specific functions. > > > > Signed-off-by: Alex Wang <al...@nicira.com> > > --- > > > > v1 -> v2: > > - coverage_run() can be called by multiple threads. > > - move min_idx and hr_idx inside coverage_run(). > > - fix the indentation. > > - use BUILD_ASSERT_DECL to check the COVERAGE_RUN_INTERVAL. > > Do you like this version, or would you prefer to make it so that only > the initial thread actually does anything in coverage_run()? Either way > is fine with me, so let me know if you'd like me to review this version > or a revised version. > > Thanks, > > Ben. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
