> > I missed that only one thread calls coverage_run(). Now that I > understand the intent, I see some other issues to resolve. First, > this intent isn't documented, but it should be (at least as a comment > on coverage_run().) >
Yes, I'll definitely refine the comment. > Second, the patch only modifies ovs-vswitchd to call coverage_run(). > We have other daemons that also should presumably call it. One can > modify each of them to call coverage_run(), but it would be better, if > possible, to avoid the need for them to manually call it, because it > is harder to miss in that case. One way to do that would be to call > it automatically from poll_block(). Either it could be made possible > to call coverage_run() from multiple threads, Yes, I can make it possible to call it from multiple threads. > or we could devise a way to have poll_block() or coverage_run() figure out > which thread is the "main thread". > I could remember the thread id of the daemons that need to run it. Could you share some more thoughts on this direction?
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
