On Thu, Aug 22, 2013 at 3:29 AM, Viresh Kumar <viresh.ku...@linaro.org> wrote:
> 2- local_bh_disable()
>
> This is how it is implemented:
>
> +void local_bh_disable(void)
> +{
> +       migrate_disable();
> +       current->softirq_nestcnt++;
> +}
> +EXPORT_SYMBOL(local_bh_disable);
>
> And here is the problem: Code currently using local_bh_disable() isn't
> guaranteed to be serialized and we better use spin_lock_bh() for them..

Putting a big lock around the majority of the packet processing
doesn't seem like a particularly good idea for performance and you
would need to make sure that you get all the entry points. You would
probably be better off serializing the parts that actually need it,
like updating stats counters.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to