Thanks Ethan for the review,
On Fri, Aug 16, 2013 at 8:07 PM, Ethan Jackson <et...@nicira.com> wrote: > This looks good to me. I have three minor comments and then it will be > ready. > > 1) It doesn't seem to apply to master for me. Would you please rebase > it and resend it? > I'll rebase it. > 2) Why are we using 2000 milliseconds as the stat collection time? In > ofproto-dpif we're guaranteed to pull stands at least once every > 1000ms. > I think I have missed something here. I only saw that the type_run() will call push_all_stats() every 2 seconds. > 3) I think we can ditch the decay_rx_count variable and increment > bfd->rx_packets directly. Perhaps I'm missing something though, in > which case what's there is fine. > This is actually necessary, since the forwarding_if_rx will use the rx_packets variable. Let's discuss it tmr. > 4) The comment above bfd_try_decay is more about how the function > works than what it does. For this reason I think it should be within > the function body not outside. > I'll adjust accordingly, thx.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
