Now that multithreading is in. Could you rework this patch to actually reconfigure the ofproto-dpif-upcall module with the appropriate setting? Basically the udpif_recv_set() function needs to be called with the appropriate value on boot, and whenever the setting changes.
I don't see any particular reason to enforce a maximum for the value. If a user wants to configure 300 threads, why not let them? It would be rather silly from a performance perspective, but the maximum seems rather arbitrary. It looks like in this code the default value is 1. I'd prefer it actually be max_online_cores - 1. I don't expect most users will actually set this, so let's default to good performance. > + n_worker_threads = MAX(1, max_online_cores - 2); Since max_online_cores is unsigned, max_online_cores - 2 will be a very large number if max_online_cores < 2. I.E this is a bug. Ethan X-CudaMail-Whitelist-To: [email protected] _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
