On Tue, Aug 13, 2013 at 08:49:19AM +0800, Ethan Jackson wrote:
> Acked-by: Ethan Jackson <et...@nicira.com>
I applied all of these. Thank you for the reviews.
> We've really got to get sparse to work with clang, this sort of thing
> is going to get annoying. C'est la vie.
I think we have a few options assuming we want to keep ovs_be<N>
(they're nice to have):
- Make sparse work with clang. (I don't think it's too hard,
at least on systems where GCC is also installed.)
- Add bitwise (or similar) support to Clang (and upstream it).
- Implement ovs_be<N> without using bitwise. For example,
instead of a typedef from uint32_t to ovs_be32, we could use
a struct that contains a single uint32_t element. But there
are lots of pitfalls in that solution, e.g. I believe that
some platforms always pad structs out to a multiple of 32
bits in length, so that this wouldn't work for ovs_be16.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
