On Wed, Aug 07, 2013 at 03:55:49PM -0700, Jesse Gross wrote:
> On Tue, Jul 30, 2013 at 5:31 PM, Joe Stringer <j...@wand.net.nz> wrote:
> > This patch adds support for rewriting SCTP src,dst ports similar to the
> > functionality already available for TCP/UDP.
> >
> > Rewriting SCTP ports is expensive due to double-recalculation of the
> > SCTP checksums; this is performed to ensure that packets traversing OVS
> > with invalid checksums will continue to the destination with any
> > checksum corruption intact.
> >
> > Reviewed-by: Simon Horman <ho...@verge.net.au>
> > Signed-off-by: Joe Stringer <j...@wand.net.nz>
>
> Ben, I think you're planning on handling the rest of this patchset but
> this one looks good to me.
>
> Acked-by: Jesse Gross <je...@nicira.com>
Jesse, this patch gives me sparse warnings building against Linux
3.2.0:
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
warning: incorrect type in argument 1 (different base types)
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
expected restricted __be32 [usertype] crc32
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
got unsigned int [unsigned] [assigned] [usertype] crc32
include/net/sctp/checksum.h:82:16: warning: cast from restricted __be32
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
warning: incorrect type in argument 1 (different base types)
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
expected restricted __be32 [usertype] crc32
/home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:
got unsigned int [unsigned] [assigned] [usertype] crc32
include/net/sctp/checksum.h:82:16: warning: cast from restricted __be32
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
