[ovs-dev] [netdev 06/27] netdev-linux: Fix fd leak on error path.

[Ben Pfaff]

Found by inspection.

Signed-off-by: Ben Pfaff <b...@nicira.com>
---
 lib/netdev-linux.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 301a754..0baa40f 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -672,19 +672,21 @@ netdev_linux_create_tap(const struct netdev_class *class 
OVS_UNUSED,
         VLOG_WARN("%s: creating tap device failed: %s", name,
                   ovs_strerror(errno));
         error = errno;
-        goto error_unref_notifier;
+        goto error_close;
     }
 
     /* Make non-blocking. */
     error = set_nonblocking(state->fd);
     if (error) {
-        goto error_unref_notifier;
+        goto error_close;
     }
 
     netdev_init(&netdev->up, name, &netdev_tap_class);
     *netdevp = &netdev->up;
     return 0;
 
+error_close:
+    close(state->fd);
 error_unref_notifier:
     cache_notifier_unref();
 error:
-- 
1.7.10.4

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev