This makes ovs-module more in-sync with upstream ovs-module. Signed-off-by: Pravin B Shelar <pshe...@nicira.com> --- datapath/flow.h | 16 ++++++++++++++++ datapath/tunnel.h | 16 ---------------- datapath/vport-gre.c | 2 +- datapath/vport-lisp.c | 2 +- datapath/vport-vxlan.c | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/datapath/flow.h b/datapath/flow.h index 59c7f6e..f7d694f 100644 --- a/datapath/flow.h +++ b/datapath/flow.h @@ -58,6 +58,22 @@ struct ovs_key_ipv4_tunnel { u8 ipv4_ttl; }; +static inline void ovs_flow_tun_key_init(struct ovs_key_ipv4_tunnel *tun_key, + const struct iphdr *iph, __be64 tun_id, + __be16 tun_flags) +{ + tun_key->tun_id = tun_id; + tun_key->ipv4_src = iph->saddr; + tun_key->ipv4_dst = iph->daddr; + tun_key->ipv4_tos = iph->tos; + tun_key->ipv4_ttl = iph->ttl; + tun_key->tun_flags = tun_flags; + + /* clear struct padding. */ + memset((unsigned char *) tun_key + OVS_TUNNEL_KEY_SIZE, 0, + sizeof(*tun_key) - OVS_TUNNEL_KEY_SIZE); +} + struct sw_flow_key { struct ovs_key_ipv4_tunnel tun_key; /* Encapsulating tunnel key. */ struct { diff --git a/datapath/tunnel.h b/datapath/tunnel.h index 17de7c4..aa52145 100644 --- a/datapath/tunnel.h +++ b/datapath/tunnel.h @@ -41,20 +41,4 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff *skb, void ovs_tnl_rcv(struct vport *vport, struct sk_buff *skb, struct ovs_key_ipv4_tunnel *tun_key); -static inline void tnl_tun_key_init(struct ovs_key_ipv4_tunnel *tun_key, - const struct iphdr *iph, __be64 tun_id, - __be16 tun_flags) -{ - tun_key->tun_id = tun_id; - tun_key->ipv4_src = iph->saddr; - tun_key->ipv4_dst = iph->daddr; - tun_key->ipv4_tos = iph->tos; - tun_key->ipv4_ttl = iph->ttl; - tun_key->tun_flags = tun_flags; - - /* clear struct padding. */ - memset((unsigned char*) tun_key + OVS_TUNNEL_KEY_SIZE, 0, - sizeof(*tun_key) - OVS_TUNNEL_KEY_SIZE); -} - #endif /* TUNNEL_H */ diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c index c74f5fc..301145b 100644 --- a/datapath/vport-gre.c +++ b/datapath/vport-gre.c @@ -112,7 +112,7 @@ static int gre_rcv(struct sk_buff *skb, return PACKET_REJECT; key = key_to_tunnel_id(tpi->key, tpi->seq); - tnl_tun_key_init(&tun_key, ip_hdr(skb), key, filter_tnl_flags(tpi->flags)); + ovs_flow_tun_key_init(&tun_key, ip_hdr(skb), key, filter_tnl_flags(tpi->flags)); ovs_vport_receive(vport, skb, &tun_key); return PACKET_RCVD; diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c index 54c10ae..6027a16 100644 --- a/datapath/vport-lisp.c +++ b/datapath/vport-lisp.c @@ -218,7 +218,7 @@ static int lisp_rcv(struct sock *sk, struct sk_buff *skb) /* Save outer tunnel values */ iph = ip_hdr(skb); - tnl_tun_key_init(&tun_key, iph, key, TUNNEL_KEY); + ovs_flow_tun_key_init(&tun_key, iph, key, TUNNEL_KEY); /* Drop non-IP inner packets */ inner_iph = (struct iphdr *)(lisph + 1); diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c index 5546820..8fdec16 100644 --- a/datapath/vport-vxlan.c +++ b/datapath/vport-vxlan.c @@ -73,7 +73,7 @@ static int vxlan_rcv(struct vxlan_handler *vh, struct sk_buff *skb, __be32 vx_vn /* Save outer tunnel values */ iph = ip_hdr(skb); key = cpu_to_be64(ntohl(vx_vni) >> 8); - tnl_tun_key_init(&tun_key, iph, key, TUNNEL_KEY); + ovs_flow_tun_key_init(&tun_key, iph, key, TUNNEL_KEY); ovs_vport_receive(vport, skb, &tun_key); return PACKET_RCVD; -- 1.7.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev