> Some of the functions take the mutex gratuitously, e.g. because they > access immutable state. One example is stp_get_name(). I guess that > these are not a big deal because this is not going to be performance > critical, but at some point we'll hit some performance-critical case > where we don't really want to have to take the lock. For cases like > that, what's the best way to suppress a warning?
There are definitely ways around the thread safety analysis. My feeling is that we should be pretty strict about it except in modules where contention is a real problem. > Why does stp need a recursive mutex? I don't see any natural > recursion here. Slightly more convenient, but I think you're right. I'll remove it. Ethan X-CudaMail-Whitelist-To: dev@openvswitch.org _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
