On Mon, Jul 29, 2013 at 10:47:47AM -0700, Ben Pfaff wrote: > On Fri, Jul 26, 2013 at 06:07:02PM -0700, Ethan Jackson wrote: > > This commit adds annotations for thread safety check. And the > > check can be conducted by using -Wthread-safety flag in clang.
One additional thought. In reading the annotations in later patches, the need to annotate a mutex as a write-lock causes a little mental dissonance for me. When I see OVS_ACQ_WRLOCK(xyzzy), I think, "Oh, xyzzy must be a read-write lock." Could we allow OVS_ACQUIRES etc. to be a synonym for use with plain mutexes? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
