I'm getting the following warning on current master (commit
dc0d542d5254c1e6 "datapath: Conditionally define skb_unclone in
datapath compat code"):
datapath/flow.c:1051:32: error: incompatible types in comparison
expression (different address spaces)
That's in ovs_masked_flow_lookup():
hlist_for_each_entry_rcu(flow, head, hash_node[table->node_ver]) {
1051 -> if (flow->mask == mask &&
__flow_cmp_key(flow, &masked_key, key_start, key_len))
return flow;
}
Last change to this line was:
commit a99c219c5d08a93f1158fcd1df0f4a429bc9062f
Author: Andy Zhou <[email protected]> Fri Jul 19 11:11:24 2013
Committer: Pravin B Shelar <[email protected]> Fri Jul 19 07:33:42 2013
datapath: Add mask check during flow lookup
A mega flow matches when the masked key matches and the mask applied
is the same as the mask used to create the mega flow.
This patch adds the implementation of the second match condition
mentioned above. Without this fix, mega flow lookup may result false
match.
Bug #18584
Signed-off-by: Andy Zhou <[email protected]>
Signed-off-by: Pravin B Shelar <[email protected]>
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
