I noticed a couple more things:
On Thu, Jul 18, 2013 at 3:22 PM, Pravin B Shelar <[email protected]> wrote:
> diff --git a/datapath/linux/compat/include/net/net_namespace.h
> b/datapath/linux/compat/include/net/net_namespace.h
> index 77f0a16..6d1f597 100644
> --- a/datapath/linux/compat/include/net/net_namespace.h
> +++ b/datapath/linux/compat/include/net/net_namespace.h
> \
> +static struct rpl_pernet_operations *pnet_##PNET_TYPE; \
> +static int compat_init_net_##PNET_TYPE(struct net *net) \
> +{ \
> + return compat_init_net(net, pnet_##PNET_TYPE); \
> +} \
> + \
> +static void compat_exit_net_##PNET_TYPE(struct net *net) \
> +{ \
> + compat_exit_net(net, pnet_##PNET_TYPE); \
> +} \
I think we lost the __net_init and __net_exit annotations when these
were moved over.
> +static int rpl_register_pernet_##PNET_TYPE(struct rpl_pernet_operations
> *rpl_pnet) \
> +{
> \
> + pnet_##PNET_TYPE = rpl_pnet;
> \
> + rpl_pnet->ops.init = compat_init_net_##PNET_TYPE;
> \
> + rpl_pnet->ops.exit = compat_exit_net_##PNET_TYPE;
> \
> + return register_pernet_##PNET_TYPE(pnet_##PNET_TYPE->id,
> &rpl_pnet->ops); \
> +}
> \
> +
> \
> +static void rpl_unregister_pernet_##PNET_TYPE(struct rpl_pernet_operations
> *rpl_pnet) \
> +{
> \
> + unregister_pernet_##PNET_TYPE(*pnet_##PNET_TYPE->id, &rpl_pnet->ops);
> \
> +}
> +#endif
>
> +#else /* For newer kernel define empty macro. */
> +#define DEFINE_COMPAT_PNET_REG_FUNC(PNET_TYPE)
> #endif /* 2.6.33 */
Aren't we missing a definition of DEFINE_COMPAT_PNET_REG_FUNC for
kernels < 2.6.32?
X-CudaMail-Whitelist-To: [email protected]
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
