On Jul 17, 2013, at 2:17 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Wed, Jul 17, 2013 at 02:04:10PM -0700, Justin Pettit wrote:
>> The "ovs-appctl dpif/dump-flows" command wasn't updated to print
>> megaflows, so the output would not include wildcards even though the
>> datapath may, so the output was inconsistent and confusing.
>>
>> Signed-off-by: Justin Pettit <jpet...@nicira.com>
>
> I think that this actually reveals a bug: the generated mask for nw_frag
> doesn't make any sense. It should be 0x3 or 0xff, not 0x2.
Wow. Good catch. I think the problem is with how we're converting the frag
mask with this function:
-=-=-=-=-=-=-=-=-=-
static uint8_t
ovs_to_odp_frag(uint8_t nw_frag)
{
return (nw_frag == 0 ? OVS_FRAG_TYPE_NONE
: nw_frag == FLOW_NW_FRAG_ANY ? OVS_FRAG_TYPE_FIRST
: OVS_FRAG_TYPE_LATER);
}
-=-=-=-=-=-=-=-=-=-
It's converting the OVS value FLOW_NW_FRAG_MASK (0x3) to the ODP value
OVS_FRAG_TYPE_LATER (0x2). I'll ask Andy to look at it.
> But the patch itself looks OK.
Thanks. I pushed it to affected branches.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
