On Mon, Jul 15, 2013 at 05:25:34PM -0700, Andy Zhou wrote: > Fix a corner case bug where ARP packet with ARP opcode value of 1 would cause > tp_src and tp_dst to appear in the output string. > > This bug caused some output from 'ovs-appctl -t ovs-l3d l3d/recorder > show' not be accepted by 'ovs-appctl ofproto/trace' > > Added test coverage by using ARP opcode 1 in one unit test case, that > would have exposed the bug. > > Bug #18334 > > Signed-off-by: Andy Zhou <az...@nicira.com>
The intended logic for setting each field's mask is "If this field's presence is implied by its prerequisites, or if it is nonzero, then set the mask." This commit doesn't really implement the latter clause properly. On the other hand, the rest of the function doesn't really do that either, and I think this commit improves behavior in practice, so I applied it to master. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
