That's even better then, thank you!
On Jul 13, 2013 9:32 AM, "Gurucharan Shetty" <shet...@nicira.com> wrote:
> On Fri, Jul 12, 2013 at 9:35 PM, Ben Pfaff <b...@nicira.com> wrote:
>
>> Thanks, this looks good. But I am surprised that "make install" does not
>> create the log directory. Perhaps that is an underlying problem that we
>> should fix instead of adding a directory creation call to every packager.
>>
> make install does create a "/var/log/openvswitch" directory. The directory
> creation call is redundant and was not needed. I should just include it in
> the files section.
>
>
>> On Jul 12, 2013 9:29 PM, "Gurucharan Shetty" <shet...@nicira.com> wrote:
>>
>>> During installation create the /var/log/openvswitch directory
>>> so that openvswitch startup script is able to write the ovs-ctl.log
>>>
>>> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
>>> ---
>>> rhel/openvswitch-fedora.spec.in | 2 ++
>>> rhel/openvswitch.spec.in | 2 ++
>>> xenserver/openvswitch-xen.spec.in | 2 ++
>>> 3 files changed, 6 insertions(+)
>>>
>>> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/
>>> openvswitch-fedora.spec.in
>>> index dc40403..cc0f9db 100644
>>> --- a/rhel/openvswitch-fedora.spec.in
>>> +++ b/rhel/openvswitch-fedora.spec.in
>>> @@ -68,6 +68,7 @@ install python/compat/uuid.py
>>> $RPM_BUILD_ROOT/usr/share/openvswitch/python
>>> install python/compat/argparse.py
>>> $RPM_BUILD_ROOT/usr/share/openvswitch/python
>>>
>>> install -d -m 755 $RPM_BUILD_ROOT/var/lib/openvswitch
>>> +install -d -m 755 $RPM_BUILD_ROOT/var/log/openvswitch
>>>
>>> %clean
>>> rm -rf $RPM_BUILD_ROOT
>>> @@ -174,6 +175,7 @@ systemctl start openvswitch.service
>>> %doc /usr/share/man/man8/ovs-test.8.gz
>>> %doc /usr/share/man/man8/ovs-l3ping.8.gz
>>> /var/lib/openvswitch
>>> +/var/log/openvswitch
>>> /usr/share/openvswitch/scripts/ovs-ctl
>>> %exclude /etc/openvswitch
>>> %exclude /usr/bin/ovs-benchmark
>>> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
>>> index 53512bc..37ec271 100644
>>> --- a/rhel/openvswitch.spec.in
>>> +++ b/rhel/openvswitch.spec.in
>>> @@ -66,6 +66,7 @@ rm \
>>> $RPM_BUILD_ROOT/usr/share/man/man8/ovs-vlan-bug-workaround.8
>>>
>>> install -d -m 755 $RPM_BUILD_ROOT/var/lib/openvswitch
>>> +install -d -m 755 $RPM_BUILD_ROOT/var/log/openvswitch
>>>
>>> %clean
>>> rm -rf $RPM_BUILD_ROOT
>>> @@ -155,3 +156,4 @@ exit 0
>>> /usr/share/doc/openvswitch-%{version}/FAQ
>>> /usr/share/doc/openvswitch-%{version}/README.RHEL
>>> /var/lib/openvswitch
>>> +/var/log/openvswitch
>>> diff --git a/xenserver/openvswitch-xen.spec.in b/xenserver/
>>> openvswitch-xen.spec.in
>>> index dff18d0..a8c6395 100644
>>> --- a/xenserver/openvswitch-xen.spec.in
>>> +++ b/xenserver/openvswitch-xen.spec.in
>>> @@ -134,6 +134,7 @@ rm \
>>> $RPM_BUILD_ROOT/usr/share/man/man8/ovs-test.8
>>>
>>> install -d -m 755 $RPM_BUILD_ROOT/var/lib/openvswitch
>>> +install -d -m 755 $RPM_BUILD_ROOT/var/log/openvswitch
>>>
>>> %clean
>>> rm -rf $RPM_BUILD_ROOT
>>> @@ -452,6 +453,7 @@ exit 0
>>> /usr/share/man/man8/ovs-vsctl.8.gz
>>> /usr/share/man/man8/ovs-vswitchd.8.gz
>>> /var/lib/openvswitch
>>> +/var/log/openvswitch
>>> %exclude /usr/lib/xsconsole/plugins-base/*.py[co]
>>> %exclude /usr/share/openvswitch/scripts/*.py[co]
>>> %exclude /usr/share/openvswitch/python/*.py[co]
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev
>>>
>>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
