Thanks, merged. Ethan
On Mon, Jul 8, 2013 at 6:39 PM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Jul 05, 2013 at 03:21:27PM -0700, Ethan Jackson wrote: >> Before this patch, facets maintained a pointer to the first rule >> used when translating their actions, and rules maintained a pointer >> to those facets. This made sense before the resubmit actions which >> each facet used precisely one rule. However, today a facet may >> require many rules to translate, and therefore it makes no >> conceptual sense to designate one as the "owning rule". >> >> Furthermore, as Open vSwitch becomes multithreaded, maintaining a >> facet's rule pointer will become more difficult. One thread will >> do the action translation, while another will maintain the facets. >> During the hand-off between these threads, it's possible the >> "owning rule" will expire leaving us with a stale pointer. >> >> This patch does have a disadvantage, Pushing a facet's statistics >> will become slightly less efficient as it will involve an >> additional classifier lookup. We can revisit this issue once >> multithreading is complete, but I suspect there's much lower >> hanging fruit to worry about. >> >> Signed-off-by: Ethan Jackson <et...@nicira.com> > > At least it simplifies bookkeeping. > > Acked-by: Ben Pfaff <b...@nicira.com> X-CudaMail-Whitelist-To: dev@openvswitch.org _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
