On Thu, Jul 04, 2013 at 02:56:29AM -0700, Ethan Jackson wrote: > Before this patch, the mirroring code would retroactively insert > actions for destination mirrors after actions were translated. > This relied on converting datapath output actions into ofports > which doesn't work for tunnels and patch ports. This patch > refactors the code to handle destination mirrors at output. > > Signed-off-by: Ethan Jackson <[email protected]>
This is much clearer and simpler. Thanks. Looking at the code, I think that there is an existing bug. The intent is to drop all packets received on ports reserved for mirroring. This is what happened in the normal action, at least, before the mirror code was factored out of it. Now, we just don't mirror the packets that arrive on such a port. Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
