I've re-written the patch following your suggestion. I think the new version I'll send out shortly is quite a bit cleaner.
Ethan On Fri, Jun 28, 2013 at 7:11 PM, Ethan Jackson <et...@nicira.com> wrote: >> What I expected to see was that each compose_output_action() would add >> the mirrors for that output to a set of mirrors to ultimately use, and >> that somewhere else (just one place) we would add the mirrors for the >> input to this same set, and that at the end we would use the set of >> mirrors to do the mirroring. >> >> What I see here is that each compose_output_action() computes the set >> of input mirrors, adds in the provided set of output mirrors, >> subtracts the mirrors already output to, and then outputs to any >> remaining ones. > > Yeah that does make more sense doesn't it . . . Perhaps the only > issue is that it doesn't work across patch ports, but neither did the > original code. I'll put some thought into it. > > Ethan X-CudaMail-Whitelist-To: dev@openvswitch.org _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
