This patch doesn't apply to master. Please be sure to rebase it before sending the next version.
> static bool bfd_in_poll(const struct bfd *); > @@ -194,6 +195,8 @@ static uint32_t generate_discriminator(void); > static void bfd_put_details(struct ds *, const struct bfd *); > static void bfd_unixctl_show(struct unixctl_conn *, int argc, > const char *argv[], void *aux OVS_UNUSED); > +static void bfd_unixctl_set_forwarding_override(struct unixctl_conn *, int > argc, > + const char *argv[], void *aux OVS_UNUSED); Would you please fix the alignment of this prototype? > + if (bfd->forwarding_override != -1) > + return (bfd->forwarding_override == 1); > + In userspace we always use curly braces. Also the parenthesis are unnecessary in the return statement. Other than that minor stuff this looks good. Go ahead and send a new version and I'll merge it. Ethan X-CudaMail-Whitelist-To: dev@openvswitch.org _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
