On Wed, May 29, 2013 at 02:24:41PM -0700, Ethan Jackson wrote:
> This patch implements a new interface to xlate_actions which, aside
> from being simpler and more intuitive, achieves several goals.  It
> pulls all of xlate_actions() results into a single structure which
> will be easier to cache and pass around in future.  And it shields
> xlate_ctx from the rest of the code, making it possible to factor
> xlate_actions() in the future (hopefully).
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>

Before I really review this, in patch 0/9 of this series, you said:

    I'd a appreciate a review of xlate_in_init(), xlate_out_uninit(),
    and xlate_actions() in the final patch of the series.  Specifically
    focusing on how the tunnel_ip_tos field of initial_vals is handled.
    Everything else backported trivially.  Once that's reviewed,
    assuming there are no objections, I'll push this.

but the handling of tunnel_ip_tos looks really simple and
straightforward.  As far as I can see, it just gets copied around.
Is there something tricky here?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to