On Wed, May 29, 2013 at 03:01:43PM -0700, Alex Wang wrote: > In ofproto-dpif.c, function vsp_realdev_to_vlandev() is called with both > OpenFlow port and datapath port number as argument. This patch replaces > the function vsp_realdev_to_vlandev() with vsp_ofp_realdev_to_vlandev() and > vsp_odp_realdev_to_vlandev(), which take OpenFlow port number and datapth > port number respectively. > > Signed-off-by: Alex Wang <al...@nicira.com>
Good catch! The existing code was written so that, if there are no VLAN splinters (the common case), then vsp_realdev_to_vlandev() does not incur the overhead of a pair of ODP-to-OFP and OFP-to-ODP translations. With this patch, I believe that we incur this overhead even when there are no VLAN splinters. Can you refactor it to avoid that, and then resubmit? I'll backport this to older branches when you do. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
