> Message: 3 > Date: Wed, 29 May 2013 10:21:28 -0700 > From: Ethan Jackson <et...@nicira.com> > Subject: [ovs-dev] [PATCH] ofproto-dpif: handle_flow_miss_common() > without facets. > To: dev@openvswitch.org > Message-ID: <1369848088-47098-1-git-send-email-et...@nicira.com> > > handle_flow_miss_common() is intended to be called whether or not a > miss needs a facet. Found by inspection. > > Signed-off-by: Ethan Jackson <et...@nicira.com> > --- > ofproto/ofproto-dpif.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index b547298..ae59eda 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -3683,6 +3683,8 @@ handle_flow_miss_without_facet(struct flow_miss *miss, > > COVERAGE_INC(facet_suppress); > > + handle_flow_miss_common(rule, packet, &miss->flow); > + > ofpbuf_use_stub(&odp_actions, op->stub, sizeof op->stub); > > dpif_flow_stats_extract(&miss->flow, packet, now, &stats); > -- > 1.7.9.5 > Is it necessary to catch this up by a unit test? Best,Jing
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
