> Would you describe it a little? It's a big patch so the fix isn't > necessarily obvious (I haven't read on yet). Is it something that we > should break out separately so that we can backport it?
It was a bug introduced in this patch. Basically facet_create() didn't set may_learn to true. I removed the statement from the commit message as it was a bit confusing. > The new odp_actions_stub in struct facet makes facets huge! This > should not be necessary. I'd use a much smaller stub there, if we > need one at all. I would consider an approach like the following. I reduced the stub length to 256 bytes. If we have 10k facets, that works out to about 3mb of extra overhead, which seems pretty reasonable to me. If we have more then 10k facets, vswitchd will likely fall over anyways. I've resent the series with your comments incorporated. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
