On Fri, May 17, 2013 at 02:42:01PM -0700, Jesse Gross wrote: > On Thu, May 16, 2013 at 11:50 PM, Simon Horman <ho...@verge.net.au> wrote: > > * Set skb->mac_len and skb->network_header to correspond to the > > end of the L3 header, including the MPLS label stack. > > I believe that the treatment of skb->mac_len is different from what > you are proposing in the OVS patch. I think this is because there is a > call to skb_reset_mac_len() in __skb_gso_segment() but it is somewhat > confusing. The GSO code is moving away from being able to reset all > header pointers and reparse the packet (obviously that's not possible > in the case of MPLS) so maybe we can just remove that call.
I agree that is likely. I will see about making it so. > > > A new NETIF_F_GRE_GSO feature is added for devices which support > > hardware MPLS GSO offload. Currently no devices support this > > and MPLS GSO always falls back to software. > > I assume that this is supposed to refer to MPLS and not GRE. Sorry about that, yes, I meant to type MPLS. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
