Looks good.
--Justin
On May 16, 2013, at 10:45 PM, Ben Pfaff <b...@nicira.com> wrote:
> 'netdev' was not initialized at this point in the function, so the cleanup
> at the error label referenced a wild pointer.
>
> Introduced in commit 94a538422d4b (netdev: Prevent using reserved names).
>
> CC: Alex Wang <al...@nicira.com>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> v1->v2: Fix Alex's email address.
> v2->v3: Fix bug I introduced noted by Justin.
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 28e306e..e10036c 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -1415,7 +1415,7 @@ iface_do_create(const struct bridge *br,
> {
> const struct ovsrec_interface *iface_cfg = if_cfg->cfg;
> const struct ovsrec_port *port_cfg = if_cfg->parent;
> - struct netdev *netdev;
> + struct netdev *netdev = NULL;
> int error;
>
> if (netdev_is_reserved_name(iface_cfg->name)) {
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
