On Fri, May 10, 2013 at 06:08:44PM -0700, Alex Wang wrote: > Two testcases are added to the testsuite, which test the new > command syntax and the corresponding corner cases. > > Signed-off-by: Alex Wang <al...@nicira.com>
Do the new tests pass for you? I get the following failure: # -*- compilation -*- 585. ofproto-dpif.at:1187: testing ofproto-dpif - ofproto/trace command 2 ... ../../tests/ofproto-dpif.at:1188: ovsdb-tool create conf.db $abs_top_srcdir/vswitchd/vswitch.ovsschema ../../tests/ofproto-dpif.at:1188: ovsdb-server --detach --no-chdir --pidfile --log-file --remote=punix:$OVS_RUNDIR/db.sock stderr: 2013-05-17T00:01:59Z|00001|vlog|INFO|opened log file /home/blp/ovs/_build/tests/testsuite.dir/0585/ovsdb-server.log ../../tests/ofproto-dpif.at:1188: sed < stderr ' /vlog|INFO|opened log file/d /ovsdb_server|INFO|ovsdb-server (Open vSwitch)/d' ../../tests/ofproto-dpif.at:1188: ovs-vsctl --no-wait init ../../tests/ofproto-dpif.at:1188: ovs-vswitchd --detach --no-chdir --pidfile --enable-dummy --disable-system --log-file -vvconn -vofproto_dpif stderr: 2013-05-17T00:01:59Z|00001|vlog|INFO|opened log file /home/blp/ovs/_build/tests/testsuite.dir/0585/ovs-vswitchd.log 2013-05-17T00:01:59Z|00002|reconnect|INFO|unix:/home/blp/ovs/_build/tests/testsuite.dir/0585/db.sock: connecting... 2013-05-17T00:01:59Z|00003|reconnect|INFO|unix:/home/blp/ovs/_build/tests/testsuite.dir/0585/db.sock: connected ../../tests/ofproto-dpif.at:1188: sed < stderr ' /vlog|INFO|opened log file/d /vswitchd|INFO|ovs-vswitchd (Open vSwitch)/d /reconnect|INFO|/d /ofproto|INFO|using datapath ID/d /ofproto|INFO|datapath ID changed to fedcba9876543210/d' ../../tests/ofproto-dpif.at:1188: ovs-vsctl -- add-br br0 -- set bridge br0 datapath-type=dummy other-config:datapath-id=fedcba9876543210 other-config:hwaddr=aa:55:aa:55:00:00 protocols=[OpenFlow10,OpenFlow12,OpenFlow13] fail-mode=secure -- ../../tests/ofproto-dpif.at:1192: ovs-ofctl add-flow br0 "in_port=1,actions=2" stdout: ../../tests/ofproto-dpif.at:1202: ovs-appctl ofproto/trace wrong_name "$odp_flow" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1202: tail -2 stderr ../../tests/ofproto-dpif.at:1202: ovs-appctl ofproto/trace wrong_name "$odp_flow" "$generate" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1202: tail -2 stderr ../../tests/ofproto-dpif.at:1202: ovs-appctl ofproto/trace wrong_name "$odp_flow" "$pkt" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1202: tail -2 stderr ../../tests/ofproto-dpif.at:1215: ovs-appctl ofproto/trace "" "$odp_flow" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1215: tail -2 stderr ../../tests/ofproto-dpif.at:1215: ovs-appctl ofproto/trace "" "$odp_flow" "$generate" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1215: tail -2 stderr ../../tests/ofproto-dpif.at:1215: ovs-appctl ofproto/trace "" "$odp_flow" "$pkt" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1215: tail -2 stderr ../../tests/ofproto-dpif.at:1229: ovs-appctl ofproto/trace ovs-system "$odp_flow" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1229: tail -2 stderr ../../tests/ofproto-dpif.at:1229: ovs-appctl ofproto/trace ovs-system "$odp_flow" "$generate" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1229: tail -2 stderr ../../tests/ofproto-dpif.at:1229: ovs-appctl ofproto/trace ovs-system "$odp_flow" "$pkt" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1229: tail -2 stderr ../../tests/ofproto-dpif.at:1242: ovs-appctl ofproto/trace br0 "$odp_flow" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1242: tail -2 stderr ../../tests/ofproto-dpif.at:1242: ovs-appctl ofproto/trace br0 "$odp_flow" "$generate" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1242: tail -2 stderr ../../tests/ofproto-dpif.at:1242: ovs-appctl ofproto/trace br0 "$odp_flow" "$pkt" stderr: Cannot find datapath of this name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1242: tail -2 stderr ../../tests/ofproto-dpif.at:1255: ovs-appctl ofproto/trace ovs-dummy "$br_flow" stderr: Unknown bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1255: tail -2 stderr ../../tests/ofproto-dpif.at:1255: ovs-appctl ofproto/trace ovs-dummy "$br_flow" "$generate" stderr: Unknown bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1255: tail -2 stderr ../../tests/ofproto-dpif.at:1255: ovs-appctl ofproto/trace ovs-dummy "$br_flow" "$pkt" stderr: Unknown bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1255: tail -2 stderr ../../tests/ofproto-dpif.at:1268: ovs-appctl ofproto/trace "$br_flow" stderr: Must specify bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1268: tail -2 stderr ../../tests/ofproto-dpif.at:1268: ovs-appctl ofproto/trace "$br_flow" "$generate" stderr: Must specify bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1268: tail -2 stderr ../../tests/ofproto-dpif.at:1268: ovs-appctl ofproto/trace "$br_flow" "$pkt" stderr: Must specify bridge name ovs-appctl: ovs-vswitchd: server returned an error ../../tests/ofproto-dpif.at:1268: tail -2 stderr ../../tests/ofproto-dpif.at:1281: ovs-vsctl add-br br1 -- set bridge br1 datapath-type=netdev \ -- set bridge br1 fail-mode=secure ../../tests/ofproto-dpif.at:1286: ovs-appctl ofproto/trace "$odp_flow" stderr: --- /dev/null 2012-08-25 09:24:53.109937360 -0700 +++ /home/blp/ovs/_build/tests/testsuite.dir/at-groups/585/stdout 2013-05-16 17:01:59.000000000 -0700 @@ -0,0 +1,7 @@ +Bridge: br0 +Flow: metadata=0,in_port=1,vlan_tci=0x0000,dl_src=50:54:00:00:00:01,dl_dst=50:54:00:00:00:02,dl_type=0x05ff +Rule: table=0 cookie=0 in_port=1 +OpenFlow actions=output:2 + +Final flow: unchanged +Datapath actions: 2 ../../tests/ofproto-dpif.at:1286: exit code was 0, expected 2 ovsdb-server.log: > 2013-05-17T00:01:59Z|00001|vlog|INFO|opened log file > /home/blp/ovs/_build/tests/testsuite.dir/0585/ovsdb-server.log > 2013-05-17T00:01:59Z|00002|ovsdb_server|INFO|ovsdb-server (Open vSwitch) > 1.11.90 ovs-vswitchd.log: > 2013-05-17T00:01:59Z|00001|vlog|INFO|opened log file > /home/blp/ovs/_build/tests/testsuite.dir/0585/ovs-vswitchd.log > 2013-05-17T00:01:59Z|00002|worker(worker)|INFO|worker process started > 2013-05-17T00:01:59Z|00002|reconnect|INFO|unix:/home/blp/ovs/_build/tests/testsuite.dir/0585/db.sock: > connecting... > 2013-05-17T00:01:59Z|00003|reconnect|INFO|unix:/home/blp/ovs/_build/tests/testsuite.dir/0585/db.sock: > connected > 2013-05-17T00:01:59Z|00004|bridge|INFO|ovs-vswitchd (Open vSwitch) 1.11.90 > 2013-05-17T00:01:59Z|00005|bridge|INFO|bridge br0: added interface br0 on > port 65534 > 2013-05-17T00:01:59Z|00006|bridge|INFO|bridge br0: using datapath ID > fedcba9876543210 > 2013-05-17T00:01:59Z|00007|connmgr|INFO|br0: added service controller > "punix:/home/blp/ovs/_build/tests/testsuite.dir/0585/br0.mgmt" > 2013-05-17T00:01:59Z|00008|ofproto_dpif|DBG|need revalidate in > ofproto_wait_cb() > 2013-05-17T00:01:59Z|00009|bridge|INFO|bridge br0: added interface p2 on port > 2 > 2013-05-17T00:01:59Z|00010|bridge|INFO|bridge br0: added interface p1 on port > 1 > 2013-05-17T00:01:59Z|00011|ofproto_dpif|DBG|need revalidate in > ofproto_wait_cb() > 2013-05-17T00:01:59Z|00012|vconn|DBG|unix: sent (Success): OFPT_HELLO (OF1.3) > (xid=0x1): > version bitmap: 0x01, 0x03, 0x04 > 2013-05-17T00:01:59Z|00013|vconn|DBG|unix: received: OFPT_HELLO (xid=0x1): > version bitmap: 0x01 > 2013-05-17T00:01:59Z|00014|vconn|DBG|unix: negotiated OpenFlow version 0x01 > (we support versions 0x01, 0x03, 0x04, peer supports version 0x01) > 2013-05-17T00:01:59Z|00015|vconn|DBG|unix: received: OFPT_FLOW_MOD (xid=0x2): > ADD in_port=1 actions=output:2 > 2013-05-17T00:01:59Z|00016|vconn|DBG|unix: received: OFPT_BARRIER_REQUEST > (xid=0x3): > 2013-05-17T00:01:59Z|00017|vconn|DBG|unix: sent (Success): OFPT_BARRIER_REPLY > (xid=0x3): > 2013-05-17T00:01:59Z|00018|ofproto_dpif|DBG|need revalidate in > ofproto_wait_cb() > 2013-05-17T00:01:59Z|00019|ofproto_dpif|WARN|couldn't open old datapath > ovs-dummy to remove it > 2013-05-17T00:01:59Z|00020|netdev_linux|WARN|ovs-netdev: creating tap device > failed: Operation not permitted > 2013-05-17T00:01:59Z|00021|dpif|WARN|failed to create datapath ovs-netdev: > Operation not permitted > 2013-05-17T00:01:59Z|00022|ofproto_dpif|ERR|failed to open datapath of type > netdev: Operation not permitted > 2013-05-17T00:01:59Z|00023|ofproto|ERR|failed to open datapath br1: Operation > not permitted > 2013-05-17T00:01:59Z|00024|bridge|ERR|failed to create bridge br1: Operation > not permitted 585. ofproto-dpif.at:1187: 585. ofproto-dpif - ofproto/trace command 2 (ofproto-dpif.at:1187): FAILED (ofproto-dpif.at:1286) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev