On Mon, May 13, 2013 at 3:29 PM, Pravin B Shelar <pshe...@nicira.com> wrote: > diff --git a/datapath/linux/compat/netdevice.c > b/datapath/linux/compat/netdevice.c > index d26fb5e..eea4c0f 100644 > --- a/datapath/linux/compat/netdevice.c > +++ b/datapath/linux/compat/netdevice.c > +struct sk_buff *rpl___skb_gso_segment(struct sk_buff *skb, > + netdev_features_t features, > + bool tx_path) > +{ > + struct sk_buff *nskb; > + char cb[sizeof(skb->cb)]; > + > + /* From 3.9 kernel skb->cb is used by skb gso. Therefore > + * make copy of it to restore it back. */ > + > + memcpy(cb, skb->cb, sizeof(cb));
We usually try to have the main code use the APIs of the most recent kernel and then add any hacks for old kernels in the compatibility code. I think this is particularly important for the upstream versions because as we upstream everything, pieces that are in compat code are likely to be missed. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev